Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 67403003: Don't lock the cursor when dragging or resizing a window with touch (Closed)

Created:
7 years, 1 month ago by tdanderson
Modified:
7 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tdresser, Rick Byers
Visibility:
Public.

Description

Don't lock the cursor when dragging or resizing a window with touch The user is already able to simultaneously move the mouse cursor while touching the screen (e.g., while touch-scrolling web contents,reordering tabs with touch, etc.), so touch-dragging or resizing a window should be no exception. Do not lock the cursor when initiating a touch drag/resize of a browser window so that a physical mousemove will show the cursor. BUG=316654 TEST=WorkspaceWindowResizerTest.MouseMoveWithTouchDrag Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234683

Patch Set 1 #

Patch Set 2 : Test added #

Patch Set 3 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tdanderson
Oshima, does this seem reasonable to you?
7 years, 1 month ago (2013-11-08 23:09:05 UTC) #1
oshima
lg. can you add test?
7 years, 1 month ago (2013-11-08 23:31:05 UTC) #2
tdanderson
Test added. @oshima, can you PTAL?
7 years, 1 month ago (2013-11-11 18:09:09 UTC) #3
oshima
lgtm
7 years, 1 month ago (2013-11-11 20:36:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/67403003/100001
7 years, 1 month ago (2013-11-11 20:45:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/67403003/300001
7 years, 1 month ago (2013-11-12 19:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/67403003/300001
7 years, 1 month ago (2013-11-12 23:46:43 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:45:49 UTC) #8
Message was sent while issue was closed.
Change committed as 234683

Powered by Google App Engine
This is Rietveld 408576698