Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 674013002: Add gn support for generating mojo_shell_apk (Closed)

Created:
6 years, 2 months ago by DaveMoore
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Naming cleanup #

Patch Set 3 : Remove ui changes for diffing #

Total comments: 6

Patch Set 4 : Address review comments #

Patch Set 5 : Alphabetize deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M mojo/services/native_viewport/BUILD.gn View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 2 3 4 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
DaveMoore
Naming cleanup
6 years, 2 months ago (2014-10-23 23:28:52 UTC) #1
DaveMoore
Remove ui changes for diffing
6 years, 2 months ago (2014-10-23 23:31:34 UTC) #2
DaveMoore
6 years, 2 months ago (2014-10-23 23:32:43 UTC) #4
jamesr
https://codereview.chromium.org/674013002/diff/40001/mojo/services/native_viewport/BUILD.gn File mojo/services/native_viewport/BUILD.gn (right): https://codereview.chromium.org/674013002/diff/40001/mojo/services/native_viewport/BUILD.gn#newcode15 mojo/services/native_viewport/BUILD.gn:15: DEPRECATED_java_in_dir = "android/src" can you use the non-DEPRECATED version? ...
6 years, 2 months ago (2014-10-23 23:35:51 UTC) #5
DaveMoore
Use short verion of native_libs
6 years, 2 months ago (2014-10-24 02:23:49 UTC) #6
DaveMoore
Alphabetize deps
6 years, 2 months ago (2014-10-24 02:25:26 UTC) #7
DaveMoore
https://codereview.chromium.org/674013002/diff/40001/mojo/services/native_viewport/BUILD.gn File mojo/services/native_viewport/BUILD.gn (right): https://codereview.chromium.org/674013002/diff/40001/mojo/services/native_viewport/BUILD.gn#newcode15 mojo/services/native_viewport/BUILD.gn:15: DEPRECATED_java_in_dir = "android/src" On 2014/10/23 23:35:50, jamesr wrote: > ...
6 years, 2 months ago (2014-10-24 02:25:48 UTC) #8
jamesr
Put sources above deps https://code.google.com/p/chromium/wiki/GNStyleGuide) then lgtm
6 years, 2 months ago (2014-10-24 03:07:09 UTC) #9
DaveMoore
6 years, 2 months ago (2014-10-24 03:55:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
c972832f10252902737e8b5acb9cecc02f23cb99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698