Issue 674003002: SimpleSlice now calls [[Get]] before [[Has]] when generating copy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 674003002: SimpleSlice now calls [[Get]] before [[Has]] when generating copy (Closed)

Created:
6 years, 1 month ago by adamk

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev, Toon Verwaest

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

SimpleSlice now calls [[Get]] before [[Has]] when generating copy SparseSlice does not need this (non-optimal) reordering since its callers guarantee that [[Get]] has no side effects on the passed-in array. BUG=v8:3643 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24884

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	src/array.js	View		1 chunk	+2 lines, -5 lines	0 comments	Download
	A	test/mjsunit/regress/regress-3643.js	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

adamk

6 years, 1 month ago (2014-10-24 18:08:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24884 (presubmit successful).