Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js

Issue 673933003: Fix some type check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js b/ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
index 9f9fce323cf89c0a46ce1f44e260b1ddf00773bc..a1443333d35bac2b3cfc4375156d4c6d22a06df8 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
@@ -181,10 +181,12 @@ function ProgressCenterPanel(element) {
/**
* Open view containing multiple progress items.
- * @type {Element}
+ * @type {!HTMLDivElement}
* @private
*/
- this.openView_ = this.element_.querySelector('#progress-center-open-view');
+ this.openView_ = assertInstanceof(
+ queryRequiredElement(this.element_, '#progress-center-open-view'),
+ HTMLDivElement);
/**
* Close view that is a summarized progress item.
@@ -310,7 +312,7 @@ ProgressCenterPanel.prototype.updateItem = function(item) {
if (newItem) {
if (!itemElement) {
itemElement = new ProgressCenterItemElement(this.element_.ownerDocument);
- this.openView_.insertBefore(itemElement, this.openView_.firstNode);
+ this.openView_.insertBefore(itemElement, this.openView_.firstChild);
hirono 2014/10/24 06:45:56 Could you keep this as it is? This is typo, but th
fukino 2014/10/27 09:11:24 Ah, OK! Thanks. Done.
}
itemElement.update(newItem, targetGroup.isAnimated(item.id));
} else {

Powered by Google App Engine
This is Rietveld 408576698