Fix some type check errors in file_manager.

Fix some type check errors in file_manager.

This CL includes following changes.
- Change openView_.firstNode to openView_.firstChild.
- Convert dynamically decorated metric functions to standard form to annotate them.
- Make MetadataCache.get's callback nullable.

BUG=406995
TEST=run browser_tests gtest_filter=*FileManager*

Committed: https://crrev.com/d17ee1b7a1b34119da680b7eca94df8dcbf16577
Cr-Commit-Position: refs/heads/master@{#301341}

[fukino, 2014-10-24 05:21:11]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2014-10-24 05:21:11]

hirono@, PTAL the CL? Thank you!

[hirono, 2014-10-24 06:45:56]

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metrics.js (right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metrics.js:76: if (metrics.log)
How about moving all the common part to metrics.call_, and just call
metrics.call_('recordSmallCount', arguments);

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
(right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js:315:
this.openView_.insertBefore(itemElement, this.openView_.firstChild);
Could you keep this as it is?
This is typo, but the behavior is correct (we should pass null here to append
the item at the end of list.
I have a patch to fix it.

[fukino, 2014-10-27 09:11:24]

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metrics.js (right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metrics.js:76: if (metrics.log)
On 2014/10/24 06:45:56, hirono wrote:
> How about moving all the common part to metrics.call_, and just call
> metrics.call_('recordSmallCount', arguments);

metrics.recordEnum() also calls metrics.call_(), but in recordEnum(),
pre-conversion of metrics name is needed. As a result,
metrics.recordSmallCount() and metrics.recordEnum() don't have much to share.

So I'd like to keep the metrics.call_() as a simple wrapper for
chrome.metricsPrivate. Sounds OK to you?

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
(right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js:315:
this.openView_.insertBefore(itemElement, this.openView_.firstChild);
On 2014/10/24 06:45:56, hirono wrote:
> Could you keep this as it is?
> This is typo, but the behavior is correct (we should pass null here to append
> the item at the end of list.
> I have a patch to fix it.

Ah, OK! Thanks.
Done.

[hirono, 2014-10-27 09:28:45]

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metrics.js (right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metrics.js:76: if (metrics.log)
On 2014/10/27 09:11:24, fukino wrote:
> On 2014/10/24 06:45:56, hirono wrote:
> > How about moving all the common part to metrics.call_, and just call
> > metrics.call_('recordSmallCount', arguments);
> 
> metrics.recordEnum() also calls metrics.call_(), but in recordEnum(),
> pre-conversion of metrics name is needed. As a result,
> metrics.recordSmallCount() and metrics.recordEnum() don't have much to share.
> 
> So I'd like to keep the metrics.call_() as a simple wrapper for
> chrome.metricsPrivate. Sounds OK to you?

How about logging part? You also would like to have it separately?
It looks we don't need to have the args local variable in each function after
moving the logging part into call_ method.

[fukino, 2014-10-27 09:41:29]

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/metrics.js (right):

https://codereview.chromium.org/673933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metrics.js:76: if (metrics.log)
On 2014/10/27 09:28:45, hirono wrote:
> On 2014/10/27 09:11:24, fukino wrote:
> > On 2014/10/24 06:45:56, hirono wrote:
> > > How about moving all the common part to metrics.call_, and just call
> > > metrics.call_('recordSmallCount', arguments);
> > 
> > metrics.recordEnum() also calls metrics.call_(), but in recordEnum(),
> > pre-conversion of metrics name is needed. As a result,
> > metrics.recordSmallCount() and metrics.recordEnum() don't have much to
share.
> > 
> > So I'd like to keep the metrics.call_() as a simple wrapper for
> > chrome.metricsPrivate. Sounds OK to you?
> 
> How about logging part? You also would like to have it separately?
> It looks we don't need to have the args local variable in each function after
> moving the logging part into call_ method.

Nice suggestion! Thanks!
I moved the logging part into call_(). Done.

[hirono, 2014-10-27 09:52:00]

lgtm! Thank you!

[fukino, 2014-10-27 10:35:16]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-10-27 10:36:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673933003/40001

[commit-bot: I haz the power, 2014-10-27 11:21:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-27 11:22:13]

Patchset 3 (id:??) landed as
https://crrev.com/d17ee1b7a1b34119da680b7eca94df8dcbf16577
Cr-Commit-Position: refs/heads/master@{#301341}