Issue 673903007: Revert harder, removing SkTaskGroup.cpp from core temporarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 673903007: Revert harder, removing SkTaskGroup.cpp from core temporarily. (Closed)

Created:
6 years, 1 month ago by mtklein_C

Modified:
6 years, 1 month ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert harder, removing SkTaskGroup.cpp from core temporarily. Not all linkers are seeing the SkThread code is not needed. BUG=skia: NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/13a8de0b511a41ead2072f9fbddfb8156c0289c7

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -2 lines)			Patch
M	gyp/SampleApp.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/core.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gyp/dm.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/pathops_skpclip.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/pathops_unittest.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673903007/1

6 years, 1 month ago (2014-10-30 15:11:45 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 15:19:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 13a8de0b511a41ead2072f9fbddfb8156c0289c7