Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 673903002: Add dependency to ax_gen for content_browser_test_utils. (Closed)

Created:
6 years, 2 months ago by aruslan
Modified:
6 years, 2 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add dependency to ax_gen for content_browser_test_utils. BUG=426437 Committed: https://crrev.com/942edf0aa04b1228e7021b165606d8ee25dc18e0 Cr-Commit-Position: refs/heads/master@{#300994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aruslan
PTAL thanks! I think I don't need to do anything for GN -- the content//test:test_support ...
6 years, 2 months ago (2014-10-23 21:54:00 UTC) #2
cjhopman
lgtm
6 years, 2 months ago (2014-10-23 22:06:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673903002/1
6 years, 2 months ago (2014-10-23 22:09:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 00:06:42 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:07:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/942edf0aa04b1228e7021b165606d8ee25dc18e0
Cr-Commit-Position: refs/heads/master@{#300994}

Powered by Google App Engine
This is Rietveld 408576698