Issue 673893002: Fix sparse versions of Array slice/splice to use [[DefineOwnProperty]] to generate return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 673893002: Fix sparse versions of Array slice/splice to use [[DefineOwnProperty]] to generate return value (Closed)

Created:
6 years, 2 months ago by adamk

Modified:
6 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
Michael Starzinger, v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix sparse versions of Array slice/splice to use [[DefineOwnProperty]] to generate return value BUG=chromium:423633 LOG=n R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24856

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/array.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	test/mjsunit/regress/regress-423633.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

adamk

If you'd prefer to switch the callers to use InternalArrays + %MoveArrayContents I can do ...

6 years, 2 months ago (2014-10-23 20:56:04 UTC) #3

adamk

6 years, 2 months ago (2014-10-23 21:13:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24856 (presubmit successful).