Issue 673883004: Chromecast: use variable internal GYP variable consistently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 673883004: Chromecast: use variable internal GYP variable consistently. (Closed)

Created:
6 years, 2 months ago by gunsch

Modified:
6 years, 1 month ago

Reviewers:
lcwu1

CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Chromecast: use variable internal GYP variable consistently. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/5a3959f46686634e1c7b380bc65d41833b5d5b19 Cr-Commit-Position: refs/heads/master@{#301458}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chromecast/chromecast.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chromecast/media/media.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673883004/1

6 years, 1 month ago (2014-10-27 20:53:04 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-10-27 22:00:15 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5a3959f46686634e1c7b380bc65d41833b5d5b19
Cr-Commit-Position: refs/heads/master@{#301458}