Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 673843003: net: add domain ID for Facebook. (Closed)

Created:
6 years, 1 month ago by agl
Modified:
6 years, 1 month ago
Reviewers:
palmer
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

net: add domain ID for Facebook. Facebook domains were added with pinning in https://codereview.chromium.org/673313002/. However, I omitted to add a new domain ID for it. This resulted in it having an ID of zero. The generation script has been updated to catch this in the future[1]. [1] https://github.com/agl/transport-security-state-generate/commit/641c7af7cac98a96386cd3fb3c4444316f8ea967 BUG=none R=palmer@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fc62f189c74d7d4756cc2911a32b2a3ae5f2467e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M net/http/transport_security_state_static.h View 2 chunks +15 lines, -14 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
agl
6 years, 1 month ago (2014-10-27 20:36:13 UTC) #2
palmer
lgtm
6 years, 1 month ago (2014-10-27 20:38:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673843003/1
6 years, 1 month ago (2014-10-27 20:40:33 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc62f189c74d7d4756cc2911a32b2a3ae5f2467e Cr-Commit-Position: refs/heads/master@{#301485}
6 years, 1 month ago (2014-10-27 23:43:08 UTC) #6
agl
6 years, 1 month ago (2014-10-27 23:43:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc62f189c74d7d4756cc2911a32b2a3ae5f2467e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698