components/BUILD.gn - Issue 673843002: Splits components/sessions into separate core and content targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index c0bf3143cb04bc2367191f1832d01b4fc6900482..fbb1cc120d6911399c80d8af9277f9fdbea229b0 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -81,7 +81,7 @@ group("all_components") {

"//components/search",

"//components/search_engines",

"//components/search_provider_logos",

- "//components/sessions",

+ "//components/sessions:sessions_content",

"//components/signin/core/browser",

"//components/startup_metric_utils",

"//components/strings",

@@ -172,7 +172,7 @@ group("all_components") {

"//components/renderer_context_menu", # Blocked on content.

"//components/search_engines", # Should work, needs checking.

"//components/search_provider_logos", # Should work, needs checking.

- "//components/sessions", # Blocked on content.

+ "//components/sessions:sessions_content", # Blocked on content.

"//components/signin/core/browser", # Should work, needs checking.

"//components/translate/content/browser", # Blocked on content.

"//components/translate/content/common", # Blocked on content.

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/components_tests.gyp » ('j') | components/sessions.gypi » ('J')