Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: components/sessions/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sessions.gypi ('k') | extensions/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 component("sessions") { 9 # TODO(rohitrao): sessions_core is defined as a source_set because it declares a
10 # static function that it does not define. This prevents it from linking as a
11 # shared_library. It also cannot be a static_library because it will be linked
12 # into multiple shared libraries. Revisit this setup if necessary.
13 source_set("sessions_core") {
10 sources = [ 14 sources = [
11 # TODO(rohitrao): Split this target into three separate core, content,
12 # and web targets.
13 "content/content_serialized_navigation_builder.cc",
14 "content/content_serialized_navigation_builder.h",
15 "content/content_serialized_navigation_driver.cc",
16 "content/content_serialized_navigation_driver.h",
17 "core/serialized_navigation_driver.h", 15 "core/serialized_navigation_driver.h",
18 "serialized_navigation_entry.cc", 16 "serialized_navigation_entry.cc",
19 "serialized_navigation_entry.h", 17 "serialized_navigation_entry.h",
20 "session_id.cc", 18 "session_id.cc",
21 "session_id.h", 19 "session_id.h",
22 ] 20 ]
23 21
24 defines = [ "SESSIONS_IMPLEMENTATION" ] 22 defines = [ "SESSIONS_IMPLEMENTATION" ]
25 23
26 deps = [ 24 deps = [
27 "//base", 25 "//base",
28 "//base/third_party/dynamic_annotations",
29 "//content/public/browser",
30 "//skia", 26 "//skia",
31 "//ui/base", 27 "//ui/base",
32 "//url", 28 "//url",
33 ] 29 ]
34 30
35 if (!is_android || !is_android_webview_build) { 31 if (!is_android || !is_android_webview_build) {
36 deps += [ "//sync" ] 32 deps += [ "//sync" ]
37 } 33 }
38 } 34 }
39 35
36 component("sessions_content") {
37 sources = [
38 "content/content_serialized_navigation_builder.cc",
39 "content/content_serialized_navigation_builder.h",
40 "content/content_serialized_navigation_driver.cc",
41 "content/content_serialized_navigation_driver.h",
42 ]
43
44 defines = [ "SESSIONS_IMPLEMENTATION" ]
45
46 deps = [
47 ":sessions_core",
48 "//base",
49 "//base/third_party/dynamic_annotations",
50 "//content/public/browser",
51 "//ui/base",
52 "//url",
53 ]
54 }
55
40 static_library("test_support") { 56 static_library("test_support") {
41 testonly = true 57 testonly = true
42 sources = [ 58 sources = [
43 "serialized_navigation_entry_test_helper.cc", 59 "serialized_navigation_entry_test_helper.cc",
44 "serialized_navigation_entry_test_helper.h", 60 "serialized_navigation_entry_test_helper.h",
45 ] 61 ]
46 62
47 deps = [ 63 deps = [
48 "//skia", 64 "//skia",
49 "//testing/gtest", 65 "//testing/gtest",
50 ] 66 ]
51 67
52 if (!is_android || !is_android_webview_build) { 68 if (!is_android || !is_android_webview_build) {
53 deps += [ "//sync" ] 69 deps += [ "//sync" ]
54 } 70 }
55 } 71 }
OLDNEW
« no previous file with comments | « components/sessions.gypi ('k') | extensions/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698