content/common/input/touch_action.h - Issue 67383002: Initial browser-side implementation for touch-action

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/input/touch_action.h

Issue 67383002: Initial browser-side implementation for touch-action (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update for new blink API - no touch ID for now Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

	6 #define CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

	7

	8 namespace content {

	9

	10 enum TouchAction {
	jdduke (slow) 2013/11/20 23:03:02 Nit: Could you perhaps put a short comment here de Nit: Could you perhaps put a short comment here describing how this type affects touch behavior? Also, I know there's been a security push recently for serialized enum types to have a \|TOUCH_ACTION_TYPE_MAX\| that you use with IPC_ENUM_TRAITS_MAX_VALUE. Rick Byers 2013/11/21 02:37:36 Done. Show quoted text On 2013/11/20 23:03:02, jdduke wrote: > > Nit: Could you perhaps put a short comment here describing how this type affects > touch behavior? Done. Show quoted text > Also, I know there's been a security push recently for serialized enum types to > have a \|TOUCH_ACTION_TYPE_MAX\| that you use with IPC_ENUM_TRAITS_MAX_VALUE. Thanks! Done.
	11 TOUCH_ACTION_NONE,

	12 TOUCH_ACTION_AUTO

	13 };

	14

	15 } // namespace content

	16

	17 #endif // CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

OLD	NEW