SetHostConfiguration() and ConfigureHost() are moved from ScreenObserver.

SetHostConfiguration() and ConfigureHost() are moved from ScreenObserver.

BUG=405876, 426651
TEST=none

Committed: https://crrev.com/bb51338bba890986ec9e4084e7c85a713c7203e8
Cr-Commit-Position: refs/heads/master@{#301363}

[ygorshenin1, 2014-10-27 13:43:43]

ygorshenin@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Nikita (slow), 2014-10-27 13:51:18]

cc:achuith

lgtm

you can use https://code.google.com/p/chromium/issues/detail?id=426651 for this
CL.

[ygorshenin1, 2014-10-27 13:53:21]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-10-27 13:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673813003/20001

[commit-bot: I haz the power, 2014-10-27 14:39:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-27 14:39:48]

Patchset 2 (id:??) landed as
https://crrev.com/bb51338bba890986ec9e4084e7c85a713c7203e8
Cr-Commit-Position: refs/heads/master@{#301363}

[achuithb, 2014-10-27 18:50:57]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2014-10-27 18:50:57]

lgtm

Thanks for cleaning this up!

A few nits that you may want to consider for the next pass through this code.

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/screens/controller_pairing_screen.h (right):

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.h:24: virtual
~Delegate() {}
nit: I believe this could be made protected

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.h:36: void
SetDelegate(Delegate* delegate);
I would just pass in the delegate in the ctor instead.

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/screens/host_pairing_screen.h (right):

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/host_pairing_screen.h:35: void
SetDelegate(Delegate* delegate);
I think passing this into the ctor cuts a few unnecessary lines of code.

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.h (right):

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.h:255: // Override from
ControllerPairingScreen::Delegate:
I'd say Overridden just to be consistent with surrounding code.

https://codereview.chromium.org/673813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.h:258: // Override from
HostPairingScreen::Delegate:
same