Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 673783005: Canvas2DLayerManager shouldn't use a task observer (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Canvas2DLayerManager shouldn't use a task observer Previously, Canvas2DLayerManager was using addTaskObserver to jump the task queue. After this CL, it goes to the end of the queue like a normal task. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1f275b190b5558c7d0652cf2fa31ae64b8099aea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M sky/engine/platform/graphics/Canvas2DLayerManager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerManager.cpp View 5 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-23 20:27:54 UTC) #1
ojan
lgtm
6 years, 2 months ago (2014-10-23 20:39:13 UTC) #3
abarth-chromium
6 years, 2 months ago (2014-10-23 21:11:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f275b190b5558c7d0652cf2fa31ae64b8099aea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698