Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3253)

Unified Diff: chrome/test/data/push_messaging/service_worker.js

Issue 673783003: BrowserTest for delivering push message to service worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushIntegrationTest2
Patch Set: Use generic data requesting class in js. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/push_messaging/service_worker.js
diff --git a/chrome/test/data/push_messaging/service_worker.js b/chrome/test/data/push_messaging/service_worker.js
index 116b355671ff082a20266841e8ebf2d2a6726a1a..e146220e3dfcc233a2327d22fd165e22f769a327 100644
--- a/chrome/test/data/push_messaging/service_worker.js
+++ b/chrome/test/data/push_messaging/service_worker.js
@@ -2,6 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Empty service worker script.
+this.onmessage = function(event) {
Peter Beverloo 2014/10/24 14:54:58 This doesn't seem to be used for anything other th
Michael van Ouwerkerk 2014/10/27 15:14:30 Deleted.
+ console.log(event);
+ console.log(event.data);
+ sendMessageToClients('message', 'Message from service worker');
+};
-// TODO(mvanouwerkerk): Add test coverage for push event delivery.
+this.onpush = function(event) {
+ console.log(event);
+ console.log(event.data);
Peter Beverloo 2014/10/24 14:54:58 nit: are the console.log() calls here necessary fo
Michael van Ouwerkerk 2014/10/27 15:14:30 Deleted.
+ sendMessageToClients('push', event.data);
+};
+
+function sendMessageToClients(type, data) {
+ var message = JSON.stringify({
+ 'type': type,
+ 'data': data
+ });
+ this.clients.getAll().then(function(clients) {
Peter Beverloo 2014/10/24 14:54:58 |this| is a bit odd here -- normally |this| would
Michael van Ouwerkerk 2014/10/27 15:14:30 Done. I think it's perfectly normal for the execut
+ clients.forEach(function(client) {
+ client.postMessage(message);
+ });
+ }, function(error) {
+ console.log(error);
+ });
+}

Powered by Google App Engine
This is Rietveld 408576698