Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 673773003: Fix extensions.gyp. (Closed)

Created:
6 years, 2 months ago by Sam McNally
Modified:
6 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@stash-mojo-subdir
Project:
chromium
Visibility:
Public.

Description

Fix extensions.gyp. This adds a missing change from https://crrev.com/680be408457f4272b468e72468eb22e1c0f0b67a NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/b9eefc9c7d0dfb211a8b451e5befbc75186f7c94 Cr-Commit-Position: refs/heads/master@{#301031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/extensions.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sam McNally
6 years, 2 months ago (2014-10-24 02:08:38 UTC) #2
benwells
lgtm
6 years, 2 months ago (2014-10-24 02:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673773003/1
6 years, 2 months ago (2014-10-24 02:10:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673773003/1
6 years, 2 months ago (2014-10-24 02:25:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 02:26:18 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 02:26:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9eefc9c7d0dfb211a8b451e5befbc75186f7c94
Cr-Commit-Position: refs/heads/master@{#301031}

Powered by Google App Engine
This is Rietveld 408576698