Deterministic recipe: Print the list of files for which zap_timestamp failed.

scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py

Index: scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
diff --git a/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py b/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
index 77169e8a1eec94d27e67c55752b2df643c2c6656..831c09685ef4d74a321af3f729df5c73e5a0f0eb 100644
--- a/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
+++ b/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
@@ -28,6 +28,7 @@ def RemovePEMetadata(build_dir, src_dir):
   with open(os.path.join(BASE_DIR, 'deterministic_build_blacklist.json')) as f:
     blacklist = frozenset(json.load(f))
 
+  failed = []
   for filename in files:
     # Ignore the blacklisted files.
     if filename in blacklist:
@@ -37,8 +38,12 @@ def RemovePEMetadata(build_dir, src_dir):
     if os.path.exists(os.path.join(build_dir, filename + '.pdb')):
       ret = RunZapTimestamp(src_dir, os.path.join(build_dir, filename))
       if ret != 0:
-        print "zap_timestamp.exe failed for %s." % filename
-        return ret
+        failed.append(filename)
+
+  if failed:
+    print >> sys.stderr, 'zap_timestamp.exe failed for the following files:'
+    print >> sys.stderr, '\n'.join('  ' + i for i in sorted(failed))
+    return 1
 

[M-A Ruel, 2014/10/23 02:01:21]

add a "return 0" at the end of the function

[Sébastien Marchand, 2014/10/23 02:03:53]

k, I thought it was implicit. 

 
 def main():