chrome/common/BUILD.gn - Issue 673663004: Android: Do not build any extensions code except for extensions_constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 673663004: Android: Do not build any extensions code except for extensions_constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zoom_controller

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index d295f52f8b49d18136024133e292d64cd0f7faba..4a1694e3af87768a628958e43b44de44fca88e75 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -62,8 +62,7 @@ static_library("common") {

"//components/variations",

"//content/public/common",

"//crypto",

- "//extensions:extensions_resources",

- "//extensions/strings",

+ "//extensions/common:common_constants",

"//media/cast:net",

"//net",

"//skia",

@@ -106,6 +105,8 @@ static_library("common") {

"//chrome/common/extensions/api",

"//extensions/common",

"//extensions/common/api",

+ "//extensions:extensions_resources",

+ "//extensions/strings",

]

}

@@ -288,8 +289,6 @@ source_set("test_support") {

visibility = [ "//chrome/test:test_support" ]

sources = [

- "extensions/extension_test_util.cc",

- "extensions/extension_test_util.h",

]

deps = [

@@ -307,4 +306,11 @@ source_set("test_support") {

]

}

+ if (enable_extensions) {

+ sources += [

+ "extensions/extension_test_util.cc",

+ "extensions/extension_test_util.h",

+ ]

+ }

}

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')