Fix regions generation on windows.

chrome/browser/ui/views/panels/panel_frame_view.cc

Index: chrome/browser/ui/views/panels/panel_frame_view.cc
diff --git a/chrome/browser/ui/views/panels/panel_frame_view.cc b/chrome/browser/ui/views/panels/panel_frame_view.cc
index aca6c2d6be4ba61e4d28e7d0418c88a55ad717c9..0e0eb133df35424d51ba3def587359faf9048885 100644
--- a/chrome/browser/ui/views/panels/panel_frame_view.cc
+++ b/chrome/browser/ui/views/panels/panel_frame_view.cc
@@ -355,7 +355,10 @@ void PanelFrameView::SetWindowCornerStyle(panel::CornerStyle corner_style) {
 
   gfx::Path window_mask;
   GetWindowMask(size(), &window_mask);
-  base::win::ScopedRegion new_region(gfx::CreateHRGNFromSkPath(window_mask));
+  base::win::ScopedRegion new_region(
+      !window_mask.isEmpty() ?
+      gfx::CreateHRGNFromSkPath(window_mask) :
+      NULL);

[Wez, 2014/10/27 20:28:39]

base::win::ScopedRegion new_region;
if (!window_mask.isEmpty())
  new_region.Set(gfx:...);

would seem more readable.

[alex-ac, 2014/10/28 10:38:35]

Done.

 
   if (current_region_result == ERROR ||
       !::EqualRgn(current_region, new_region)) {

[Wez, 2014/10/27 20:28:39]

Does EqualRgn actually return true for (NULL, NULL)? MSDN doesn't document that
case.

[alex-ac, 2014/10/28 10:38:35]

EqualRgn will return ERROR if one of handles is invalid. I've added check for
new_region == NULL.