Issue 673583002: Remove wtf_ceil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 673583002: Remove wtf_ceil. (Closed)

Created:
6 years, 2 months ago by tkent

Modified:
6 years, 2 months ago

Reviewers:
tasak, eseidel

CC:
blink-reviews, blink-reviews-html_chromium.org, mkwst+moarreviews_chromium.org, dglazkov+blink, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove wtf_ceil. According to a post by Darin Adler [1], OSX older than SnowLeopard had the ceil() bug. We don't support the older versions of OSX. This CL also renames LayoutUnit::wtf_ceil and Decimal::ceiling. [1] https://bugs.webkit.org/show_bug.cgi?id=78032#c8 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184171

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -49 lines)			Patch
M	Source/core/html/forms/InputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/Decimal.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/Decimal.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/platform/DecimalTest.cpp	View	1 chunk	+31 lines, -31 lines	0 comments	Download
M	Source/platform/LayoutUnit.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/wtf/MathExtras.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673583002/1

6 years, 2 months ago (2014-10-22 11:15:40 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 11:21:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184171

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages