Issue 673573002: Files.app: Move fileNameInput element under the dialogFooter class.

Issue 673573002: Files.app: Move fileNameInput element under the dialogFooter class. (Closed)

Created:
6 years, 2 months ago by hirono

Modified:
6 years, 2 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Files.app: Move fileNameInput element under the dialogFooter class. BUG=267281 TEST=None Committed: https://crrev.com/1d36c98a6bab20dc61cd3b88aac394807d338802 Cr-Commit-Position: refs/heads/master@{#300665}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -85 lines)			Patch
M	ui/file_manager/file_manager/foreground/js/file_manager.js	View	1	13 chunks	+41 lines, -80 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/file_selection.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js	View	1 2	4 chunks	+69 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

fukino

On 2014/10/22 09:26:21, hirono wrote: > PTAL the CL? Thank you! lgtm. Thank you!

6 years, 2 months ago (2014-10-22 09:47:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673573002/40001

6 years, 2 months ago (2014-10-22 09:51:49 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 11:12:45 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/1d36c98a6bab20dc61cd3b88aac394807d338802
Cr-Commit-Position: refs/heads/master@{#300665}