Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 673503002: Rename BrowserActionView to ToolbarActionView (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename BrowserActionView to ToolbarActionView BrowserActionViews now represent significantly more than just Browser Actions. Rename it to ToolbarActionView. BUG=426448 Committed: https://crrev.com/fdc6f645c57aa0a054166743d1614ddaf32ab4c0 Cr-Commit-Position: refs/heads/master@{#300944}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -676 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D chrome/browser/ui/views/toolbar/browser_action_view.h View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 10 chunks +38 lines, -40 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 30 chunks +81 lines, -81 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/toolbar/chevron_menu_button.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/toolbar/toolbar_action_view.h View 5 chunks +18 lines, -25 lines 0 comments Download
A + chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 11 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Devlin
Just a simple rename - no functional changes.
6 years, 2 months ago (2014-10-23 18:08:06 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-23 19:54:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673503002/40001
6 years, 2 months ago (2014-10-23 19:59:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years, 2 months ago (2014-10-23 20:50:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fdc6f645c57aa0a054166743d1614ddaf32ab4c0 Cr-Commit-Position: refs/heads/master@{#300944}
6 years, 2 months ago (2014-10-23 20:51:00 UTC) #9
yzshen1
6 years, 2 months ago (2014-10-23 22:36:53 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/675893002/ by yzshen@chromium.org.

The reason for reverting is: Failed
ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks
on Linux ChromiumOS Tests (dbg)(1) and Linux Tests (dbg)(1)(32).

[23680:23680:1023/150443:FATAL:browser_actions_container.cc(1021)] Check failed:
model_->toolbar_items().size() == toolbar_action_views_.size() (0 vs. 1).

Powered by Google App Engine
This is Rietveld 408576698