Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 673373002: [Telemetry] Remove RunTaskExecutionTime method (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove RunTaskExecutionTime method BUG=418375 Committed: https://crrev.com/02d750113b2e1863619d5c397edf22bbeb4e3cb6 Cr-Commit-Position: refs/heads/master@{#301374}

Patch Set 1 #

Patch Set 2 : Remove RunTaskExecutionTime in unittest and tough_scheduling_cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M tools/perf/measurements/task_execution_time.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nednguyen
6 years, 2 months ago (2014-10-24 23:34:23 UTC) #2
Sami
lgtm. I don't think we want to do any special interaction for task execution times, ...
6 years, 1 month ago (2014-10-27 12:39:45 UTC) #4
Sami
Oops, You'll need to update tools/perf/page_sets/tough_scheduling_cases.py too.
6 years, 1 month ago (2014-10-27 12:40:40 UTC) #5
picksi1
No, this should be OK. I'd kept them separate in case we needed it in ...
6 years, 1 month ago (2014-10-27 12:47:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673373002/20001
6 years, 1 month ago (2014-10-27 15:11:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 16:11:25 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:12:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02d750113b2e1863619d5c397edf22bbeb4e3cb6
Cr-Commit-Position: refs/heads/master@{#301374}

Powered by Google App Engine
This is Rietveld 408576698