Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 673283002: Bit shift the bmAttributes field to interpret isochronous endpoint. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
rpaquay
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bit shift the bmAttributes field to interpret isochronous endpoint. The bit fields holding information about the synchronization mode and intended usage of an isochronous pipe need to be shifted before they are compared to the libusb enums. Otherwise a NOTREACHED is hit because the unshifted values are out of range. BUG=426910 Committed: https://crrev.com/8df07cfa2108991fb979c2b009ee1ace5b055c6f Cr-Commit-Position: refs/heads/master@{#301169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M device/usb/usb_device_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
6 years, 1 month ago (2014-10-24 18:01:10 UTC) #2
rpaquay
lgtm
6 years, 1 month ago (2014-10-24 18:08:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673283002/1
6 years, 1 month ago (2014-10-24 18:35:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 19:26:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 19:26:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df07cfa2108991fb979c2b009ee1ace5b055c6f
Cr-Commit-Position: refs/heads/master@{#301169}

Powered by Google App Engine
This is Rietveld 408576698