Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 673253005: Revert of Add a has_media flag to VolumeMetadata. (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a has_media flag to VolumeMetadata. (patchset #3 id:40001 of https://codereview.chromium.org/668013004/) Reason for revert: Suspected to have caused failure of test FileManagerPrivateApiTest.Mount https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/33105 Original issue's description: > Add a has_media flag to VolumeMetadata. > > The new flag carries the has_media status of a volume through from the DiskMountManager, so the information is available to chrome.fileManagerPrivate.onMountCompleted javascript listeners. > > BUG=420680 > > Committed: https://crrev.com/7accfac4f10afbba205c87ca66a59c35775c695e > Cr-Commit-Position: refs/heads/master@{#301144} TBR=smckay@chromium.org,mkearney@chromium.org,mtomasz@chromium.org,kenobi@google.com,kenobi@chromium.org NOTREECHECKS=true NOTRY=true BUG=420680 Committed: https://crrev.com/3c8c255f2d552ee1aca0d254e57eabdf7e056203 Cr-Commit-Position: refs/heads/master@{#301187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qyearsley
Created Revert of Add a has_media flag to VolumeMetadata.
6 years, 2 months ago (2014-10-24 20:28:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673253005/1
6 years, 2 months ago (2014-10-24 20:29:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 20:30:17 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 20:30:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c8c255f2d552ee1aca0d254e57eabdf7e056203
Cr-Commit-Position: refs/heads/master@{#301187}

Powered by Google App Engine
This is Rietveld 408576698