Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: runtime/vm/object.cc

Issue 673253002: Add missing StorePointer/StoreSmi in ContextScope. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 41280)
+++ runtime/vm/object.cc (working copy)
@@ -12561,7 +12561,8 @@
void ContextScope::SetTokenIndexAt(intptr_t scope_index,
intptr_t token_pos) const {
- VariableDescAddr(scope_index)->token_pos = Smi::New(token_pos);
+ StoreSmi(&VariableDescAddr(scope_index)->token_pos,
+ Smi::New(token_pos));
}
@@ -12581,7 +12582,8 @@
void ContextScope::SetIsFinalAt(intptr_t scope_index, bool is_final) const {
- VariableDescAddr(scope_index)->is_final = Bool::Get(is_final).raw();
+ StorePointer(&(VariableDescAddr(scope_index)->is_final),
+ Bool::Get(is_final).raw());
}
@@ -12591,7 +12593,8 @@
void ContextScope::SetIsConstAt(intptr_t scope_index, bool is_const) const {
- VariableDescAddr(scope_index)->is_const = Bool::Get(is_const).raw();
+ StorePointer(&(VariableDescAddr(scope_index)->is_const),
+ Bool::Get(is_const).raw());
}
@@ -12627,7 +12630,8 @@
void ContextScope::SetContextIndexAt(intptr_t scope_index,
intptr_t context_index) const {
- VariableDescAddr(scope_index)->context_index = Smi::New(context_index);
+ StoreSmi(&(VariableDescAddr(scope_index)->context_index),
+ Smi::New(context_index));
}
@@ -12638,7 +12642,8 @@
void ContextScope::SetContextLevelAt(intptr_t scope_index,
intptr_t context_level) const {
- VariableDescAddr(scope_index)->context_level = Smi::New(context_level);
+ StoreSmi(&(VariableDescAddr(scope_index)->context_level),
+ Smi::New(context_level));
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | runtime/vm/raw_object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698