Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 673203002: TurboFan calls to vector-based ics need to resolve a slot to an index. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

TurboFan calls to vector-based ics need to resolve a slot to an index. This is to cope with the recent division of the TypeFeedbackVector into Slots and ICSlots. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/js-generic-lowering.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Michael, a simple update, ptal thanks! --Michael
6 years, 2 months ago (2014-10-24 12:00:48 UTC) #1
Michael Starzinger
LGTM.
6 years, 2 months ago (2014-10-24 12:32:05 UTC) #2
mvstanton
6 years, 2 months ago (2014-10-24 12:39:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698