[DevTools] Extract platform module.

[DevTools] Extract platform module.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184865

[dgozman, 2014-10-24 13:47:11]

dgozman@chromium.org changed reviewers:
+ apavlov@chromium.org, pfeldman@chromium.org

[dgozman, 2014-10-24 13:47:12]

Take a look please.

[pfeldman, 2014-10-24 15:41:28]

lgtm

[dgozman, 2014-10-24 20:18:26]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:19:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673163004/20001

[commit-bot: I haz the power, 2014-10-24 21:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 21:23:48]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[apavlov, 2014-10-31 13:26:25]

apavlov@chromium.org changed reviewers:
+ vsevik@chromium.org

[apavlov, 2014-10-31 13:26:26]

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
File Source/devtools/devtools.gypi (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
Source/devtools/devtools.gypi:73: 'devtools_platform_js_files': [
We should preserve the alphabetic order (I agree it's not the case now). Can you
at least move this to 'devtools_bindings_js_files'?

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
Source/devtools/devtools.gypi:451: 'front_end/platform/Promise.js',
alpha-order

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (left):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:213:
this._loadAutoStartModules(coreModuleNames).done();
This is critical to the correct rejection handling, AFAIK. Please consult with
pfeldman@ for more details.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:344:
Promise.all(moduleJSONPromises).then(instantiateRuntime).done();
Ditto

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:141: var thenCallback =
scriptSourceLoaded.bind(null, i);
Why this change? It's a very sensitive snippet that has changed a few times this
week.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:424: Runtime._console = console;
I'd rather vsevik@ take a look at this, as I'm not sure this duplication is
good.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/platform/Promise.js (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/platform/Promise.js:61: console = console;
This is not quite related to promises

[dgozman, 2014-10-31 13:56:06]

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
File Source/devtools/devtools.gypi (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
Source/devtools/devtools.gypi:73: 'devtools_platform_js_files': [
On 2014/10/31 13:26:26, apavlov wrote:
> We should preserve the alphabetic order (I agree it's not the case now). Can
you
> at least move this to 'devtools_bindings_js_files'?

Done.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/devtools...
Source/devtools/devtools.gypi:451: 'front_end/platform/Promise.js',
On 2014/10/31 13:26:26, apavlov wrote:
> alpha-order

Done.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (left):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:213:
this._loadAutoStartModules(coreModuleNames).done();
On 2014/10/31 13:26:26, apavlov wrote:
> This is critical to the correct rejection handling, AFAIK. Please consult with
> pfeldman@ for more details.

Restored with a local version.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:141: var thenCallback =
scriptSourceLoaded.bind(null, i);
On 2014/10/31 13:26:26, apavlov wrote:
> Why this change? It's a very sensitive snippet that has changed a few times
this
> week.

Copied from Promise.js, as this file cannot does not depend on module.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:424: Runtime._console = console;
On 2014/10/31 13:26:26, apavlov wrote:
> I'd rather vsevik@ take a look at this, as I'm not sure this duplication is
> good.

We can't do this without duplication.

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/platform/Promise.js (right):

https://codereview.chromium.org/673163004/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/platform/Promise.js:61: console = console;
On 2014/10/31 13:26:26, apavlov wrote:
> This is not quite related to promises

Moved to utilities.

[dgozman, 2014-10-31 13:56:15]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-31 13:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673163004/40002

[commit-bot: I haz the power, 2014-10-31 16:19:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 16:19:39]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34610)

[dgozman, 2014-10-31 19:26:35]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:26:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673163004/40002

[commit-bot: I haz the power, 2014-10-31 21:11:45]

Committed patchset #4 (id:40002) as 184753

[lushnikov, 2014-11-01 14:10:30]

A revert of this CL (patchset #4 id:40002) has been created in
https://codereview.chromium.org/692343002/ by lushnikov@chromium.org.

The reason for reverting is: This breaks DevTools at least in a hosted mode: the
front-end does not load, exceptions are thrown from Runtime.js.

[dgozman, 2014-11-05 10:26:55]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-11-05 10:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673163004/70001

[commit-bot: I haz the power, 2014-11-05 11:43:34]

Committed patchset #5 (id:70001) as 184865