Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: content/common/swapped_out_messages.cc

Issue 67313010: Fix frame detach message and lifetime issues for the mainframe RenderFrameImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add impl comment. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/swapped_out_messages.cc
diff --git a/content/common/swapped_out_messages.cc b/content/common/swapped_out_messages.cc
index 05b5781b9151afc974b80bfbd86df5a6a596f300..47acc358e02733cf7385b46f54dabd8cf4c01e83 100644
--- a/content/common/swapped_out_messages.cc
+++ b/content/common/swapped_out_messages.cc
@@ -5,6 +5,7 @@
#include "content/common/swapped_out_messages.h"
#include "content/common/accessibility_messages.h"
+#include "content/common/frame_messages.h"
#include "content/common/input_messages.h"
#include "content/common/view_messages.h"
#include "content/public/common/content_client.h"
@@ -35,6 +36,8 @@ bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
// Allow cross-process JavaScript calls.
case ViewHostMsg_RouteCloseEvent::ID:
case ViewHostMsg_RouteMessageEvent::ID:
+ // Frame detach must occur after the RenderView has swapped out.
+ case FrameHostMsg_Detach::ID:
return true;
default:
break;
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698