Issue 67313009: BidiResolver needs to know when it reached the end of the line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67313009: BidiResolver needs to know when it reached the end of the line. (Closed)

Created:
7 years, 1 month ago by igoroliveira

Modified:
7 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed, eseidel

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

InlineBidiResolver::appendRun should notify BidiResolver that it reached the end of the line. BUG=317423 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161890

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, --1 lines)			Patch
A	LayoutTests/fast/text/international/bidi-crash-reached-end-of-line.html	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/text/international/bidi-crash-reached-end-of-line-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/rendering/InlineIterator.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/67313009/1

7 years, 1 month ago (2013-11-13 07:36:30 UTC) #3

Message was sent while issue was closed.

Change committed as 161890