Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67313006: Delete IBusClient. (Closed)

Created:
7 years, 1 month ago by Hiro Komatsu
Modified:
7 years, 1 month ago
Reviewers:
satorux1, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, pneubeck (no reviews)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Delete IBusClient. IBusClient is no longer necessary. This patch cleans up the code. BUG=317500 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234763

Patch Set 1 #

Total comments: 6

Patch Set 2 : Tweaked code based on the review. #

Patch Set 3 : Rebased. #

Patch Set 4 : Remove obsolete test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -506 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 2 3 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 5 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 3 10 chunks +7 lines, -39 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 5 chunks +0 lines, -15 lines 0 comments Download
D chromeos/dbus/ibus/ibus_client.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chromeos/dbus/ibus/ibus_client.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_client.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_client.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chromeos/ime/ibus_daemon_controller.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 2 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Hiro Komatsu
7 years, 1 month ago (2013-11-11 08:22:00 UTC) #1
Seigo Nonaka
lgtm with nits https://codereview.chromium.org/67313006/diff/1/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/67313006/diff/1/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode114 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:114: RegisterComponent(); Register component is still necessary? ...
7 years, 1 month ago (2013-11-12 03:21:44 UTC) #2
satorux1
chromeos/dbus LGTM
7 years, 1 month ago (2013-11-12 04:29:21 UTC) #3
Hiro Komatsu
https://codereview.chromium.org/67313006/diff/1/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/67313006/diff/1/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode114 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:114: RegisterComponent(); On 2013/11/12 03:21:45, Seigo Nonaka wrote: > Register ...
7 years, 1 month ago (2013-11-12 04:34:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/67313006/110001
7 years, 1 month ago (2013-11-12 04:37:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=174098
7 years, 1 month ago (2013-11-12 05:36:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/67313006/80003
7 years, 1 month ago (2013-11-12 07:35:11 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 08:11:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/67313006/80003
7 years, 1 month ago (2013-11-12 09:18:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=174152
7 years, 1 month ago (2013-11-12 10:31:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/67313006/630001
7 years, 1 month ago (2013-11-12 15:06:53 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-12 18:33:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/67313006/630001
7 years, 1 month ago (2013-11-13 02:02:36 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 05:51:32 UTC) #14
Message was sent while issue was closed. 
Change committed as 234763

Powered by Google App Engine
This is Rietveld 408576698