Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 67313005: Remove duplicated headers from the testing/ directory (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
Reviewers:
eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove duplicated headers from the testing/ directory where the implementation file includes the same dependencies as the corresponding primary header. BUG=317231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/testing/plugin/PluginObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/plugin/PluginTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/CppBoundClass.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/CppVariant.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/EventSender.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/testing/runner/MockWebRTCDataChannelHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/MockWebRTCPeerConnectionHandler.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/testing/runner/NotificationPresenter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/TestRunner.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/testing/runner/WebAXObjectProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/testing/runner/WebTestThemeControlWin.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
few trivial changes.
7 years, 1 month ago (2013-11-10 17:34:03 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-11-11 20:59:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/67313005/1
7 years, 1 month ago (2013-11-11 21:00:28 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 00:21:38 UTC) #4
Message was sent while issue was closed.
Change committed as 161743

Powered by Google App Engine
This is Rietveld 408576698