Issue 6731091: Fixing tryserver config mistakes preventing master restart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6731091: Fixing tryserver config mistakes preventing master restart. (Closed)

Created:
9 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Matt Ball

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

Description

Fixing tryserver config mistakes preventing master restart. (All this can go away soon once everything's on the annotator.) BUG=None TEST=None TBR=mball@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79852

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	masters/master.tryserver.nacl/master.cfg	View		5 chunks	+9 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Ball

9 years, 8 months ago (2011-03-30 17:26:55 UTC) #2

LGTM

Just one minor comment.

Cheers,
-Matt

http://codereview.chromium.org/6731091/diff/1/masters/master.tryserver.nacl/m...
File masters/master.tryserver.nacl/master.cfg (right):

http://codereview.chromium.org/6731091/diff/1/masters/master.tryserver.nacl/m...
masters/master.tryserver.nacl/master.cfg:90: builder_name=None, target=None,
project=None,
Shouldn't we just change the default to be 'dbg' instead of None?

http://codereview.chromium.org/6731091/diff/1/masters/master.tryserver.nacl/m...
masters/master.tryserver.nacl/master.cfg:101: target = 'dbg'
Could this be removed if we change the default of target to be 'dbg'?

Expand Messages | Collapse Messages