webkit/fileapi/file_system_operation.h - Issue 6731033: Remove the path from PlatformFileInfo; it's cleaner just to pass it along as a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_operation.h

Issue 6731033: Remove the path from PlatformFileInfo; it's cleaner just to pass it along as a (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webkit/fileapi/file_system_file_util_proxy.h ('K') | « webkit/fileapi/file_system_file_util_proxy.cc ('k') | webkit/fileapi/file_system_operation.cc » ('j') | webkit/plugins/ppapi/file_callbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/fileapi/file_system_operation.h

===================================================================

--- webkit/fileapi/file_system_operation.h (revision 79323)

+++ webkit/fileapi/file_system_operation.h (working copy)

@@ -112,11 +112,14 @@

void DidFinishFileOperation(base::PlatformFileError rv);

void DidDirectoryExists(base::PlatformFileError rv,

- const base::PlatformFileInfo& file_info);

+ const base::PlatformFileInfo& file_info,

+ const FilePath&);

kinuko 2011/03/25 22:39:54 nit: in chromium I don't think we usually omit (un

kinuko 2011/03/25 22:44:43 Found that this wasn't really true, though I remem

ericu 2011/03/28 20:24:34 I added them back in as "unused".

void DidFileExists(base::PlatformFileError rv,

- const base::PlatformFileInfo& file_info);

+ const base::PlatformFileInfo& file_info,

+ const FilePath&);

void DidGetMetadata(base::PlatformFileError rv,

- const base::PlatformFileInfo& file_info);

+ const base::PlatformFileInfo& file_info,

+ const FilePath& platform_path);

void DidReadDirectory(

base::PlatformFileError rv,

const std::vector<base::FileUtilProxy::Entry>& entries);