Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webkit/tools/test_shell/simple_file_writer.cc

Issue 6731033: Remove the path from PlatformFileInfo; it's cleaner just to pass it along as a (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/tools/test_shell/simple_file_system.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/tools/test_shell/simple_file_writer.h" 5 #include "webkit/tools/test_shell/simple_file_writer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop_proxy.h" 8 #include "base/message_loop_proxy.h"
9 #include "net/url_request/url_request_context.h" 9 #include "net/url_request/url_request_context.h"
10 #include "webkit/fileapi/file_system_callback_dispatcher.h" 10 #include "webkit/fileapi/file_system_callback_dispatcher.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 } 97 }
98 98
99 virtual void DidFail(base::PlatformFileError error_code) { 99 virtual void DidFail(base::PlatformFileError error_code) {
100 proxy_->DidFail(error_code); 100 proxy_->DidFail(error_code);
101 } 101 }
102 102
103 virtual void DidWrite(int64 bytes, bool complete) { 103 virtual void DidWrite(int64 bytes, bool complete) {
104 proxy_->DidWrite(bytes, complete); 104 proxy_->DidWrite(bytes, complete);
105 } 105 }
106 106
107 virtual void DidReadMetadata(const base::PlatformFileInfo&) { 107 virtual void DidReadMetadata(
108 const base::PlatformFileInfo&,
109 const FilePath&) {
108 NOTREACHED(); 110 NOTREACHED();
109 } 111 }
110 112
111 virtual void DidReadDirectory( 113 virtual void DidReadDirectory(
112 const std::vector<base::FileUtilProxy::Entry>& entries, 114 const std::vector<base::FileUtilProxy::Entry>& entries,
113 bool has_more) { 115 bool has_more) {
114 NOTREACHED(); 116 NOTREACHED();
115 } 117 }
116 118
117 virtual void DidOpenFileSystem(const std::string& name, 119 virtual void DidOpenFileSystem(
118 const FilePath& root_path) { 120 const std::string& name,
121 const FilePath& root_path) {
119 NOTREACHED(); 122 NOTREACHED();
120 } 123 }
121 124
122 scoped_refptr<IOThreadProxy> proxy_; 125 scoped_refptr<IOThreadProxy> proxy_;
123 }; 126 };
124 127
125 FileSystemOperation* GetNewOperation() { 128 FileSystemOperation* GetNewOperation() {
126 // The FileSystemOperation takes ownership of the CallbackDispatcher. 129 // The FileSystemOperation takes ownership of the CallbackDispatcher.
127 return new FileSystemOperation(new CallbackDispatcher(this), 130 return new FileSystemOperation(new CallbackDispatcher(this),
128 io_thread_, file_system_context_.get(), 131 io_thread_, file_system_context_.get(),
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 196 }
194 197
195 void SimpleFileWriter::DoWrite( 198 void SimpleFileWriter::DoWrite(
196 const FilePath& path, const GURL& blob_url, int64 offset) { 199 const FilePath& path, const GURL& blob_url, int64 offset) {
197 io_thread_proxy_->Write(path, blob_url, offset); 200 io_thread_proxy_->Write(path, blob_url, offset);
198 } 201 }
199 202
200 void SimpleFileWriter::DoCancel() { 203 void SimpleFileWriter::DoCancel() {
201 io_thread_proxy_->Cancel(); 204 io_thread_proxy_->Cancel();
202 } 205 }
OLDNEW
« no previous file with comments | « webkit/tools/test_shell/simple_file_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698