Remove the path from PlatformFileInfo; it's cleaner just to pass it along as a

webkit/fileapi/file_system_operation.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_H_
 
 #include <vector>
 
 #include "base/file_path.h"
@@ skipping 94 matching lines @@
                                     bool created);
 
   // Callback for CreateFile for |exclusive|=false cases.
   void DidEnsureFileExistsNonExclusive(base::PlatformFileError rv,
                                        bool created);
 
   // Generic callback that translates platform errors to WebKit error codes.
   void DidFinishFileOperation(base::PlatformFileError rv);
 
   void DidDirectoryExists(base::PlatformFileError rv,
-                          const base::PlatformFileInfo& file_info);
+                          const base::PlatformFileInfo& file_info,
+                          const FilePath&);

[kinuko, 2011/03/25 22:39:54]

nit: in chromium I don't think we usually omit (unused) parameter names.

[kinuko, 2011/03/25 22:44:43]

Found that this wasn't really true, though I remember I was told that by someone
before... I'll leave this tiny style nit to you.

[ericu, 2011/03/28 20:24:34]

I added them back in as "unused".

   void DidFileExists(base::PlatformFileError rv,
-                     const base::PlatformFileInfo& file_info);
+                     const base::PlatformFileInfo& file_info,
+                     const FilePath&);
   void DidGetMetadata(base::PlatformFileError rv,
-                      const base::PlatformFileInfo& file_info);
+                      const base::PlatformFileInfo& file_info,
+                      const FilePath& platform_path);
   void DidReadDirectory(
       base::PlatformFileError rv,
       const std::vector<base::FileUtilProxy::Entry>& entries);
   void DidWrite(
       base::PlatformFileError rv,
       int64 bytes,
       bool complete);
   void DidTouchFile(base::PlatformFileError rv);
 
   // Helper for Write().
@@ skipping 71 matching lines @@
   scoped_ptr<FileWriterDelegate> file_writer_delegate_;
   scoped_ptr<net::URLRequest> blob_request_;
   scoped_ptr<FileSystemOperation> cancel_operation_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemOperation);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_OPERATION_H_