Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 673073002: Fix border parsing to work again (Closed)

Created:
6 years, 2 months ago by eseidel
Modified:
6 years, 2 months ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Fix border parsing to work again I accidentally broke border parsing when removing CSS color keyword hacks. While debugging this I also ran into a race condition in the debugger, which is fixed here. Add --gdb argument to skydb Makes it trivial to drop into gdb having launched mojo_shell/sky with the right arguments. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fcf34dcff70e5feb687f888cd1fed91027b62acf

Patch Set 1 #

Patch Set 2 : Remove included change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eseidel
6 years, 2 months ago (2014-10-23 23:48:29 UTC) #2
ojan
lgtm
6 years, 2 months ago (2014-10-23 23:53:45 UTC) #3
eseidel
Committed patchset #2 (id:20001) manually as fcf34dcff70e5feb687f888cd1fed91027b62acf (presubmit successful).
6 years, 2 months ago (2014-10-23 23:54:25 UTC) #4
abarth-chromium
Is there a test for the border color bug?
6 years, 2 months ago (2014-10-24 01:47:50 UTC) #6
eseidel
6 years, 2 months ago (2014-10-24 05:54:54 UTC) #7
Message was sent while issue was closed.
Yeah, I just forgot to add it to the CL.  I'll land it in the morning.

Powered by Google App Engine
This is Rietveld 408576698