Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 673063002: Fix "#if defined(DEBUG)" statements (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix "#if defined(DEBUG)" statements A few "#if defined(DEBUG)" statements made it into chrome. Of course, there is no DEBUG, there's only NDEBUG. Tweak these to be "#if !defined(NDEBUG), and make them compile. Committed: https://crrev.com/91834baeb5436bca0e6eb4b452bb773cd8c3b211 Cr-Commit-Position: refs/heads/master@{#301012}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Peter's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 3 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
Peter, mind taking a quick look?
6 years, 2 months ago (2014-10-23 23:11:10 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/673063002/diff/1/chrome/browser/ui/views/toolbar/browser_actions_container.cc File chrome/browser/ui/views/toolbar/browser_actions_container.cc (right): https://codereview.chromium.org/673063002/diff/1/chrome/browser/ui/views/toolbar/browser_actions_container.cc#newcode759 chrome/browser/ui/views/toolbar/browser_actions_container.cc:759: DCHECK(GetViewForExtension(extension) == nullptr) << Nit: Maybe DCHECK(!GetViewForExtension(extension))
6 years, 2 months ago (2014-10-24 00:01:03 UTC) #3
Devlin
https://codereview.chromium.org/673063002/diff/1/chrome/browser/ui/views/toolbar/browser_actions_container.cc File chrome/browser/ui/views/toolbar/browser_actions_container.cc (right): https://codereview.chromium.org/673063002/diff/1/chrome/browser/ui/views/toolbar/browser_actions_container.cc#newcode759 chrome/browser/ui/views/toolbar/browser_actions_container.cc:759: DCHECK(GetViewForExtension(extension) == nullptr) << On 2014/10/24 00:01:02, Peter Kasting ...
6 years, 2 months ago (2014-10-24 00:14:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673063002/20001
6 years, 2 months ago (2014-10-24 00:17:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 01:08:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 01:09:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91834baeb5436bca0e6eb4b452bb773cd8c3b211
Cr-Commit-Position: refs/heads/master@{#301012}

Powered by Google App Engine
This is Rietveld 408576698