Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 673003002: Replace USE_ASH with USE_AURA in web_contents_modal_dialog_manager_views.cc (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
Reviewers:
Mike Wittman, msw
CC:
chromium-reviews, tfarina, wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace USE_ASH with USE_AURA in web_contents_modal_dialog_manager_views.cc BUG=None TEST=None R=wittman Committed: https://crrev.com/96aaf02809cc669e8d406cc9c7787652ec372473 Cr-Commit-Position: refs/heads/master@{#300963}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 4 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
wittman@ PTAL
6 years, 2 months ago (2014-10-23 20:05:28 UTC) #2
Mike Wittman
I'm not familiar enough with the current state of Aura and Ash to review this. ...
6 years, 2 months ago (2014-10-23 20:46:27 UTC) #4
msw
I guess if this isn't using any ash-specific code, and the desktop host doesn't actually ...
6 years, 2 months ago (2014-10-23 20:56:13 UTC) #5
pkotwicz
I should have given more context. Desktop Chrome for Linux and Windows uses Ash. I ...
6 years, 2 months ago (2014-10-23 21:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673003002/20001
6 years, 2 months ago (2014-10-23 21:21:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-23 22:40:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 22:40:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96aaf02809cc669e8d406cc9c7787652ec372473
Cr-Commit-Position: refs/heads/master@{#300963}

Powered by Google App Engine
This is Rietveld 408576698