Navigation transitions (web to native app): Clear navigation transition data

Navigation transitions (web to native app): Clear navigation transition data

For web to web navigation transition, the data is cleared
in RenderFrameHostManager::ResumeResponseDeferredAtStart().
For web to native app navigation transition, it will never
reach that point because no actual URL request was sent
out. In this case, clank side will call to clear navigation
transition data when the user navigate back from the native
app.

BUG=370696
Committed: https://crrev.com/1f790352e0ccf87ace78a01594ca334bf79c29ad
Cr-Commit-Position: refs/heads/master@{#301984}

[Zhen Wang, 2014-10-24 13:22:52]

zhenw@chromium.org changed reviewers:
+ oysteine@chromium.org, sievers@chromium.org

[Zhen Wang, 2014-10-24 13:22:53]

ptal

[oystein (OOO til 10th of July), 2014-10-27 18:58:29]

https://codereview.chromium.org/672973003/diff/60001/content/browser/web_cont...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/672973003/diff/60001/content/browser/web_cont...
content/browser/web_contents/web_contents_impl.h:199: void
ClearNavigationTransitionData();
nit: comment?

https://codereview.chromium.org/672973003/diff/60001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/672973003/diff/60001/content/public/android/j...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:157:
public void clearNavigationTransitionData();
Is this only called for navigation transitions, or is it always called whenever
the user returns to the browser? If it's the latter maybe the function should be
renamed to something more generic (onWhatever).

[Zhen Wang, 2014-10-27 21:49:38]

https://codereview.chromium.org/672973003/diff/60001/content/browser/web_cont...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/672973003/diff/60001/content/browser/web_cont...
content/browser/web_contents/web_contents_impl.h:199: void
ClearNavigationTransitionData();
On 2014/10/27 18:58:28, Oystein wrote:
> nit: comment?

Done.

https://codereview.chromium.org/672973003/diff/60001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/672973003/diff/60001/content/public/android/j...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:157:
public void clearNavigationTransitionData();
This is only called for navigation transitions.

[oystein (OOO til 10th of July), 2014-10-29 21:37:48]

lgtm

[no sievers, 2014-10-29 23:07:23]

lgtm

[Zhen Wang, 2014-10-29 23:12:59]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2014-10-29 23:14:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/672973003/100001

[commit-bot: I haz the power, 2014-10-30 00:06:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-30 00:07:14]

Patchset 6 (id:??) landed as
https://crrev.com/1f790352e0ccf87ace78a01594ca334bf79c29ad
Cr-Commit-Position: refs/heads/master@{#301984}