Issue 672873002: Revert "Simplify TurboFan's c1visualizer file handling."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672873002: Revert "Simplify TurboFan's c1visualizer file handling." (Closed)

Created:
6 years, 2 months ago by Sven Panne

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Simplify TurboFan's c1visualizer file handling." This reverts r24819, it broke the build on Mac due to header incompatibilities. TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24821

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -17 lines)			Patch
M	src/compiler/pipeline.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	6 chunks	+35 lines, -9 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	2 chunks	+13 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Sven Panne

Committed patchset #1 (id:1) manually as 24821 (tree was closed).

6 years, 2 months ago (2014-10-23 07:36:50 UTC) #1

Message was sent while issue was closed.

lgtm