Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672863003: Don't use MIP filter mode on compressed textures (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skgr
Visibility:
Public.

Description

Don't use MIP filter mode on compressed textures Add compressed texture image downsample GMs BUG=chromium:426331 Committed: https://skia.googlesource.com/skia/+/efd7d45fc0fc5f2b924c774c5d38ce546f35f3ca

Patch Set 1 #

Total comments: 1

Patch Set 2 : wrap lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
6 years, 2 months ago (2014-10-23 20:28:36 UTC) #2
egdaniel
lgtm + nits https://codereview.chromium.org/672863003/diff/1/gm/downsamplebitmap.cpp File gm/downsamplebitmap.cpp (right): https://codereview.chromium.org/672863003/diff/1/gm/downsamplebitmap.cpp#newcode197 gm/downsamplebitmap.cpp:197: DEF_GM( return new DownsampleBitmapImageGM("mandrill_132x132_12x12.astc", SkPaint::kHigh_FilterLevel); ) ...
6 years, 2 months ago (2014-10-23 21:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672863003/20001
6 years, 2 months ago (2014-10-23 21:09:24 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 21:17:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as efd7d45fc0fc5f2b924c774c5d38ce546f35f3ca

Powered by Google App Engine
This is Rietveld 408576698