components/sync_driver/device_info_data_type_controller.cc - Issue 672863002: Sync: fix crash in DeviceInfoDataTypeController::Subscription destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_data_type_controller.cc

Issue 672863002: Sync: fix crash in DeviceInfoDataTypeController::Subscription destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/device_info_data_type_controller.h ('k') | components/sync_driver/device_info_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_data_type_controller.cc

diff --git a/components/sync_driver/device_info_data_type_controller.cc b/components/sync_driver/device_info_data_type_controller.cc

index 592633dc815a2cd93c7c573cf69ce0ee9c089d8d..f1e7499b318dfa9f4dd23906474c3f7e94ddcff7 100644

--- a/components/sync_driver/device_info_data_type_controller.cc

+++ b/components/sync_driver/device_info_data_type_controller.cc

@@ -37,6 +37,10 @@ bool DeviceInfoDataTypeController::StartModels() {

return false;

}

+void DeviceInfoDataTypeController::StopModels() {

+ subscription_.reset();

void DeviceInfoDataTypeController::OnLocalDeviceInfoLoaded() {

DCHECK_EQ(state_, MODEL_STARTING);

DCHECK(local_device_info_provider_->GetLocalDeviceInfo());