Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 672853002: Implement "auto -> angle" animation on <marker> orient attribute. (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers, tasak
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement "auto -> angle" animation on <marker> orient attribute. Before this CL, "angle -> auto" animation was implemented but "auto -> angle" animation was not implemented. This CL implements the missing piece as a discrete animation as specified in the spec. BUG=425848 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -57 lines) Patch
A + LayoutTests/svg/animations/animate-marker-orient-from-auto-to-angle.html View 4 chunks +15 lines, -9 lines 0 comments Download
A + LayoutTests/svg/animations/animate-marker-orient-from-auto-to-angle-expected.txt View 3 chunks +12 lines, -14 lines 0 comments Download
M Source/core/svg/SVGAngle.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAngle.cpp View 2 chunks +28 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kouhei (in TOK)
Would you take a look?
6 years, 2 months ago (2014-10-23 06:13:23 UTC) #2
fs
lgtm
6 years, 2 months ago (2014-10-23 08:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672853002/1
6 years, 2 months ago (2014-10-23 08:27:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33235)
6 years, 2 months ago (2014-10-23 10:13:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672853002/1
6 years, 2 months ago (2014-10-23 10:14:17 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 12:17:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184260

Powered by Google App Engine
This is Rietveld 408576698