Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Issue 67283005: Adding GitHub repos to doc server (Closed)

Created:
7 years, 1 month ago by mkearney1
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Adding GitHub repos to doc server Repos include webstore, devtools, and multidevice. R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234245

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/json/content_providers.json View 1 2 3 4 5 6 7 8 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mkearney1
Ben, I'm not getting any error messages; however, I'm not able to see raw content ...
7 years, 1 month ago (2013-11-08 23:51:53 UTC) #1
mkearney1
On 2013/11/08 23:51:53, mkearney1 wrote: > Ben, > > I'm not getting any error messages; ...
7 years, 1 month ago (2013-11-08 23:52:43 UTC) #2
not at google - send to devlin
Ok sorry about that Meggin. If you patch in https://codereview.chromium.org/61893015 it will work. I'll get ...
7 years, 1 month ago (2013-11-11 04:21:33 UTC) #3
not at google - send to devlin
lgtm apart from nit https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json File chrome/common/extensions/docs/templates/json/content_providers.json (right): https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json#newcode71 chrome/common/extensions/docs/templates/json/content_providers.json:71: "devtools-docs": { nit: alphabetical order ...
7 years, 1 month ago (2013-11-11 04:23:16 UTC) #4
not at google - send to devlin
lgtm apart from nit https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json File chrome/common/extensions/docs/templates/json/content_providers.json (right): https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json#newcode71 chrome/common/extensions/docs/templates/json/content_providers.json:71: "devtools-docs": { nit: alphabetical order ...
7 years, 1 month ago (2013-11-11 04:23:16 UTC) #5
not at google - send to devlin
lgtm apart from nit
7 years, 1 month ago (2013-11-11 04:23:17 UTC) #6
mkearney1
https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json File chrome/common/extensions/docs/templates/json/content_providers.json (right): https://codereview.chromium.org/67283005/diff/170001/chrome/common/extensions/docs/templates/json/content_providers.json#newcode71 chrome/common/extensions/docs/templates/json/content_providers.json:71: "devtools-docs": { On 2013/11/11 04:23:16, kalman wrote: > nit: ...
7 years, 1 month ago (2013-11-11 18:10:03 UTC) #7
mkearney1
7 years, 1 month ago (2013-11-11 18:34:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #9 manually as r234245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698