Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7310)

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

Issue 67283003: Disabled flaky PhishingClassifierTest.DisableDetection on Mac OS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
index 9ae14f7b2f322ae7dcaa93877fc5420111ef27c8..db6d2823d169847b87e10f477e7cc447f393b72e 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
@@ -267,7 +267,14 @@ IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, TestClassification) {
EXPECT_EQ(PhishingClassifier::kInvalidScore, phishy_score);
}
-IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, DisableDetection) {
+// Flaky on Mac Blink bots: crbug.com/316709
+#if defined(OS_MACOSX)
+#define MAYBE_DisableDetection DISABLED_DisableDetection
+#else
+#define MAYBE_DisableDetection DisableDetection
+#endif
+
+IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, MAYBE_DisableDetection) {
// No scorer yet, so the classifier is not ready.
EXPECT_FALSE(classifier_->is_ready());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698