Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672823002: Remove IsDIPEnabled from Screen (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tdanderson+views_chromium.org, sadrul, qsr+mojo_chromium.org, Aaron Boodman, tfarina, ben+aura_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, ben+views_chromium.org, ben+ash_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dpi-cleanup-1
Project:
chromium
Visibility:
Public.

Description

Remove IsDIPEnabled from Screen Appears to be unused. TBR=ben@chromium.org R=sky@chromium.org BUG=143619 Committed: https://crrev.com/23a0f218f7126e3abc8ce39ca9986411a465d048 Cr-Commit-Position: refs/heads/master@{#300906}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -74 lines) Patch
M ash/display/screen_ash.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/screen_ash.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M athena/env/athena_env_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/capture_web_contents_function.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M mojo/aura/screen_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/aura/screen_mojo.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/layout.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/gfx/screen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/screen_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/screen_ios.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/screen_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/screen_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/screen_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
scottmg
https://codereview.chromium.org/672823002/diff/1/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc File chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc (left): https://codereview.chromium.org/672823002/diff/1/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc#oldcode30 chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc:30: return false; This is the only non-"return true".
6 years, 2 months ago (2014-10-23 02:51:20 UTC) #2
sky
nice, LGTM
6 years, 2 months ago (2014-10-23 04:17:26 UTC) #3
oshima
lgtm
6 years, 2 months ago (2014-10-23 05:04:01 UTC) #4
scottmg
tbr ben for mojo/aura/
6 years, 2 months ago (2014-10-23 05:37:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672823002/20001
6 years, 2 months ago (2014-10-23 05:38:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19471)
6 years, 2 months ago (2014-10-23 05:44:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672823002/20001
6 years, 2 months ago (2014-10-23 16:14:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 16:56:33 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 16:57:19 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/23a0f218f7126e3abc8ce39ca9986411a465d048
Cr-Commit-Position: refs/heads/master@{#300906}

Powered by Google App Engine
This is Rietveld 408576698