Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(50)

Issue 6728027: Move modem command to the modem-utilities repository (Closed)

Created:
8 years, 4 months ago by Jason Glasgow
Modified:
8 years, 3 months ago
Reviewers:
Eric Shienbrood
CC:
chromium-os-reviews_chromium.org, Eric Shienbrood, rochberg, Elly Fong-Jones, Jason Glasgow, Nathan Williams
Visibility:
Public.

Description

Move modem command to the modem-utilities repository See also http://codereview.chromium.org/6780027/ BUG=chrome-os-partner:2985 TEST=build modem-utilities & gobi-cromo-plugin. Verify modem command in crosh Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4c9d5b9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove crud. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, --1 lines) Patch
A Makefile View 1 1 chunk +11 lines, -0 lines 0 comments Download
A WATCHLISTS View 1 chunk +18 lines, -0 lines 0 comments Download
A inherit-review-settings-ok View 0 chunks +-1 lines, --1 lines 0 comments Download
A mm.sh View 1 chunk +58 lines, -0 lines 0 comments Download
A modem View 1 chunk +249 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jason Glasgow
Can you take a look at this?
8 years, 4 months ago (2011-03-31 17:12:53 UTC) #1
Eric Shienbrood
http://codereview.chromium.org/6728027/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6728027/diff/1/Makefile#newcode5 Makefile:5: INSTALL_TARGETS = install-production What does this variable definition do?
8 years, 4 months ago (2011-03-31 17:31:41 UTC) #2
Jason Glasgow
PTAL http://codereview.chromium.org/6728027/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6728027/diff/1/Makefile#newcode5 Makefile:5: INSTALL_TARGETS = install-production Absolutely nothing. Removed. Thanks.
8 years, 4 months ago (2011-03-31 17:47:54 UTC) #3
Eric Shienbrood
8 years, 4 months ago (2011-03-31 18:14:51 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698