media/base/channel_mixer_unittest.cc - Issue 672793002: Expose the internal MatrixBuilder class as ChannelMixingMatrix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/channel_mixer_unittest.cc

Issue 672793002: Expose the internal MatrixBuilder class as ChannelMixingMatrix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/channel_mixer_unittest.cc

diff --git a/media/base/channel_mixer_unittest.cc b/media/base/channel_mixer_unittest.cc

index ac228e661dd39bb5869b4e98ddafa624807cdc4a..e07d95110ee362385f10da13be7ae2823eb234a0 100644

--- a/media/base/channel_mixer_unittest.cc

+++ b/media/base/channel_mixer_unittest.cc

@@ -24,6 +24,7 @@ TEST(ChannelMixerTest, ConstructAllPossibleLayouts) {

input_layout <= CHANNEL_LAYOUT_MAX;

input_layout = static_cast<ChannelLayout>(input_layout + 1)) {

for (ChannelLayout output_layout = CHANNEL_LAYOUT_MONO;

+ // TODO(wtc): why do we only test up to CHANNEL_LAYOUT_STEREO_DOWNMIX?

output_layout < CHANNEL_LAYOUT_STEREO_DOWNMIX;

output_layout = static_cast<ChannelLayout>(output_layout + 1)) {

// DISCRETE can't be tested here based on the current approach.

« no previous file with comments | « media/base/channel_mixer.cc ('k') | media/base/channel_mixing_matrix.h » ('j') | no next file with comments »